Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAC-17 User Authentication #38

Merged
merged 45 commits into from
Feb 2, 2024
Merged

Conversation

DOOduneye
Copy link
Contributor

@DOOduneye DOOduneye commented Jan 21, 2024

Description

Link to Ticket

Please include a summary of the changes and the related issue. Please also
include relevant motivation, context, and images!

Implemented RBAC with JWT Tokens for access and refresh,

TODOs:

  • token blacklist
  • revocation
  • token versioning

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. If they are unit
tests, provide the file name the tests are in. If they are not unit tests,
describe how you tested the change.

No tests yet

Checklist

  • I have performed a self-review of my code
  • I have reached out to another developer to review my code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@garrettladley garrettladley changed the title Sac 17 user authentication SAC-17 User Authentication Jan 21, 2024
@DOOduneye DOOduneye self-assigned this Jan 31, 2024
Copy link
Member

@garrettladley garrettladley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goated work @melodyyu754 @DOOduneye 🐐 some nits and conflicts then you're good to merge

backend/src/auth/tokens.go Outdated Show resolved Hide resolved
backend/src/auth/tokens.go Outdated Show resolved Hide resolved
backend/tests/api/auth_unit_test.go Outdated Show resolved Hide resolved
backend/src/transactions/user.go Show resolved Hide resolved
backend/src/transactions/club.go Outdated Show resolved Hide resolved
backend/src/middleware/club.go Outdated Show resolved Hide resolved
backend/src/middleware/auth.go Outdated Show resolved Hide resolved
backend/src/middleware/auth.go Outdated Show resolved Hide resolved
backend/src/auth/tokens.go Show resolved Hide resolved
backend/src/auth/tokens.go Show resolved Hide resolved
@DOOduneye DOOduneye marked this pull request as ready for review February 1, 2024 16:42
DOOduneye and others added 4 commits February 1, 2024 14:33
Co-authored-by: Garrett Ladley <92384606+garrettladley@users.noreply.github.com>
Co-authored-by: Garrett Ladley <92384606+garrettladley@users.noreply.github.com>
Co-authored-by: Garrett Ladley <92384606+garrettladley@users.noreply.github.com>
Co-authored-by: Garrett Ladley <92384606+garrettladley@users.noreply.github.com>
backend/src/controllers/user.go Outdated Show resolved Hide resolved
backend/src/controllers/user.go Outdated Show resolved Hide resolved
backend/src/auth/tokens.go Outdated Show resolved Hide resolved
backend/src/auth/tokens.go Show resolved Hide resolved
backend/src/auth/tokens.go Show resolved Hide resolved
backend/src/models/user.go Show resolved Hide resolved
backend/src/server/server.go Outdated Show resolved Hide resolved
backend/src/server/server.go Outdated Show resolved Hide resolved
backend/src/services/auth.go Outdated Show resolved Hide resolved
backend/src/models/membership.go Show resolved Hide resolved
garrettladley and others added 15 commits February 1, 2024 15:40
Co-authored-by: David Oduneye <44040421+DOOduneye@users.noreply.github.com>
Co-authored-by: David Oduneye <44040421+DOOduneye@users.noreply.github.com>
commit 66ba683
Author: David Oduneye <44040421+DOOduneye@users.noreply.github.com>
Date:   Thu Feb 1 20:27:57 2024 -0500

    feat: updated cli (#138)

commit 1673ef0
Author: Garrett Ladley <92384606+garrettladley@users.noreply.github.com>
Date:   Thu Feb 1 14:15:19 2024 -0500

    GHWF Updates (#136)

commit def8176
Author: Garrett Ladley <92384606+garrettladley@users.noreply.github.com>
Date:   Thu Feb 1 13:58:05 2024 -0500

    Fix: CodeQL Running Too Often (#135)

commit fa30a32
Author: garrettladley <ladley.g@northeastern.edu>
Date:   Thu Feb 1 13:55:30 2024 -0500

    Revert "resolves #133"

    This reverts commit 08d253f.

commit 08d253f
Author: garrettladley <ladley.g@northeastern.edu>
Date:   Thu Feb 1 13:52:15 2024 -0500

    resolves #133

commit c1b7f01
Author: Garrett Ladley <92384606+garrettladley@users.noreply.github.com>
Date:   Thu Feb 1 01:38:24 2024 -0500

    Fixed Format Step in GitHub Workflow (#131)

commit d786b9f
Author: Garrett Ladley <92384606+garrettladley@users.noreply.github.com>
Date:   Wed Jan 31 23:47:10 2024 -0500

    Added Support for Slack and Email Contact Types (#129)

commit 83b1ef8
Author: Garrett Ladley <92384606+garrettladley@users.noreply.github.com>
Date:   Wed Jan 31 18:27:33 2024 -0500

    Refactor Tags Routes to be Under Categories (#119)

commit c66a3e7
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Jan 31 13:35:29 2024 -0500

    Bump the npm_and_yarn group across 1 directories with 1 update (#117)

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@garrettladley garrettladley merged commit e2c3dbb into main Feb 2, 2024
2 of 3 checks passed
@garrettladley garrettladley deleted the SAC-17-User-Authentication branch February 2, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants