restrict isRequestComplete to only the related oracle response #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
isRequestComplete
to be consistent withisRequestFailed
such that it only considers the oracle response that resulted from the request. This provides consistency across the implementation while sacrificing the Witnet order backfill behaviour for requests; meaning that a request will only be considered complete if it's oracle response returned successfully.The original issue points out a problem that arises from the inconsistent interface where an RNG request can be considered both failed and completed at the same time. This change enforces a consistent interface between the two so bots can make decisions in a more predictable environment.