Deprecate the ugly perspective -JG syntax and introduce a modern form#5780
Merged
PaulWessel merged 11 commits intomasterfrom Sep 20, 2021
Merged
Deprecate the ugly perspective -JG syntax and introduce a modern form#5780PaulWessel merged 11 commits intomasterfrom
PaulWessel merged 11 commits intomasterfrom
Conversation
While this is backwards compatible, the new form uses optional modifiers. This PR updates the documentation, the example script in the cookbook, but have not changed the test scripts (yet) to make sure both forms work.
PaulWessel
added
documentation
Esteban82
approved these changes
Sep 18, 2021
PaulWessel
changed the title
maxrjones
added
add-changelog
Member
Author
|
While @Esteban82 has approved this one (since it works), if anyone has comments or changes to the particular choices of modifiers then now is a good time. FYI, here is the three test results for varying altitude, azimuth, and view restriction: Altitude: Azimuth: View: |
maxrjones
reviewed
Sep 19, 2021
maxrjones
reviewed
Sep 20, 2021
Member
maxrjones
left a comment
maxrjones
left a comment
There was a problem hiding this comment.
New syntax looks nice. I did not test it since that's already been done.
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Member
|
Is this supposed to work this way? I get a flip image when I add +du to the width
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this is backwards compatible, the new form uses optional modifiers. This PR updates the documentation, the example script in the cookbook, but have not changed the test scripts (yet) to make sure both forms work.
New syntax
-Jg|Glon0/lat0/scale|width[+aazimuth][+ttilt][+vvwidth/vheight][+wtwist][+zaltitude]
Old syntax
-Jg|Glon0/lat0/altitude/azimuth/tilt/twist/Width/Height/scale|width
I have added three new tests that explores variations in azimuth, altitude, and view window. I will add similar tests for twist and tilt later.
The documentation, doc examples, doc scripts and animations using the perspective projection have been updated to reflect the new syntax. We will leave old tests scripts for backwards testing and add new scripts using the modernized format.