Apply suggestions from code review

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>

Author: willschlitzer

pygmt/__init__.py

@@ -47,8 +47,8 @@
     grdtrack,
     info,
     makecpt,
-    sphinterpolate,
     sphdistance,
+    sphinterpolate,
     surface,
     which,
     x2sys_cross,

pygmt/src/__init__.py

@@ -35,8 +35,8 @@
 from pygmt.src.plot3d import plot3d
 from pygmt.src.rose import rose
 from pygmt.src.solar import solar
-from pygmt.src.sphinterpolate import sphinterpolate
 from pygmt.src.sphdistance import sphdistance
+from pygmt.src.sphinterpolate import sphinterpolate
 from pygmt.src.subplot import set_panel, subplot
 from pygmt.src.surface import surface
 from pygmt.src.text import text_ as text  # "text" is an argument within "text_"

pygmt/src/sphinterpolate.py

@@ -21,7 +21,7 @@
     V="verbose",
 )
 @kwargs_to_strings(I="sequence", R="sequence")
-def sphinterpolate(table, **kwargs):
+def sphinterpolate(data, **kwargs):
     r"""
     Create spherical grid files in tension of data.
 
@@ -36,7 +36,7 @@ def sphinterpolate(table, **kwargs):
 
     Parameters
     ----------
-    table : str or {table-like}
+    data : str or {table-like}
         Pass in (x, y, z) or (longitude, latitude, elevation) values by
         providing a file name to an ASCII data table, a 2D
         {table-classes}.
@@ -58,13 +58,12 @@ def sphinterpolate(table, **kwargs):
     """
     with GMTTempFile(suffix=".nc") as tmpfile:
         with Session() as lib:
-            file_context = lib.virtualfile_from_data(check_kind="vector", data=table)
+            file_context = lib.virtualfile_from_data(check_kind="vector", data=data)
             with file_context as infile:
                 if "G" not in kwargs.keys():  # if outgrid is unset, output to tempfile
                     kwargs.update({"G": tmpfile.name})
                 outgrid = kwargs["G"]
-                arg_str = build_arg_string(kwargs)
-                arg_str = " ".join([infile, arg_str])
+                arg_str = " ".join([infile, build_arg_string(kwargs)])
                 lib.call_module("sphinterpolate", arg_str)
 
         return load_dataarray(outgrid) if outgrid == tmpfile.name else None

pygmt/tests/test_sphinterpolate.py

@@ -14,7 +14,7 @@ def test_sphinterpolate_outgrid():
     """
     with GMTTempFile(suffix=".nc") as tmpfile:
         result = sphinterpolate(
-            table="@mars370d.txt", outgrid=tmpfile.name, spacing=1, region="g"
+            data="@mars370d.txt", outgrid=tmpfile.name, spacing=1, region="g"
         )
         assert result is None  # return value is None
         assert os.path.exists(path=tmpfile.name)  # check that outgrid exists
@@ -24,7 +24,7 @@ def test_sphinterpolate_no_outgrid():
     """
     Test sphinterpolate with no set outgrid.
     """
-    temp_grid = sphinterpolate(table="@mars370d.txt", spacing=1, region="g")
+    temp_grid = sphinterpolate(data="@mars370d.txt", spacing=1, region="g")
     assert temp_grid.dims == ("lat", "lon")
     assert temp_grid.gmt.gtype == 1  # Geographic grid
     assert temp_grid.gmt.registration == 0  # Gridline registration