Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken 'Improve this page' links using sphinx variable page_source_suffix #1969

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Jun 19, 2022

Description of proposed changes

suffix is not a sphinx global variable. Instead, it's a variable defined by the sphinx_rtd_theme, which was removed in readthedocs/sphinx_rtd_theme#1104.

Fixes #1968

@seisman seisman marked this pull request as ready for review June 19, 2022 09:47
@seisman seisman added the maintenance Boring but important stuff for the core devs label Jun 19, 2022
@seisman seisman changed the title Fix the broken links for 'Improve this page' Fix the broken links for 'Improve this page' using sphinx variable page_source_suffix Jun 19, 2022
@seisman seisman changed the title Fix the broken links for 'Improve this page' using sphinx variable page_source_suffix Fix broken links for 'Improve this page' using sphinx variable page_source_suffix Jun 19, 2022
@seisman seisman added this to the 0.7.0 milestone Jun 19, 2022
@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Jun 22, 2022
@weiji14 weiji14 changed the title Fix broken links for 'Improve this page' using sphinx variable page_source_suffix Fix broken 'Improve this page' links using sphinx variable page_source_suffix Jun 22, 2022
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jun 22, 2022
@seisman seisman merged commit 93e75ca into main Jun 22, 2022
@seisman seisman deleted the fix-improve-this-page branch June 22, 2022 13:51
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Improve this page" button doesn't work
2 participants