Add support for frontend v2 for nuxt #1345
Conversation
| @@ -105,6 +105,7 @@ export async function getAllFilesFromCurrentPath( | |||
| export async function zipDirectory( | |||
| sourceDir: string, | |||
| outPath: string, | |||
| includeHiddenFiles: boolean = false, | |||
There was a problem hiding this comment.
I think this should be true by default.
So before this change dot: true, hence all of the previous method calls assume that hidden files will be included by default, right?
There was a problem hiding this comment.
It doesn't matter. I changed in all places where this is used. The default value is for future usage and I think false is a more safe default value.
There was a problem hiding this comment.
It's okay to let it be false, but can you also update the following references:
https://github.com/Genez-io/genezio/blob/dev/src/commands/bundle.ts#L117
https://github.com/Genez-io/genezio/blob/dev/src/bundlers/dart/dartBundler.ts#L214
| const presignedUrlForProjectCode = await getPresignedURLForProjectCodePush(region, name, stage); | ||
| return uploadContentToS3( |
There was a problem hiding this comment.
I think we should clean tmpFolderProject here with something like:
await deleteFolder(path.dirname(tmpFolderProject));
There was a problem hiding this comment.
All temporary folders are already deleted at process exit:
Line 40 in a5e3ea5
There was a problem hiding this comment.
My bad, disregard my comment
| [ | ||
| "**/node_modules/*", | ||
| "./node_modules/*", | ||
| "node_modules/*", | ||
| "**/node_modules", | ||
| "./node_modules", | ||
| "node_modules", | ||
| "node_modules/**", | ||
| "**/node_modules/**", | ||
| ], |
There was a problem hiding this comment.
It seems to me that the exclusion list is smaller than it was before refactoring.
I believe we are adding the .git directory and any other temporary directories used by vercel, opennnext in the zip.
Is this something we want?
I think we should at least keep ignoring the .git related stuff.
There was a problem hiding this comment.
All dot files and folders are ignored. That's why I did the change with zipDirectory.
| presignedUrlForProjectCode, | ||
| path.join(tmpFolderProject, "projectCode.zip"), | ||
| ); | ||
| await uploadUserCode(configuration.name, configuration.region, options.stage); |
There was a problem hiding this comment.
Thanks for doing this refactoring! It was DEFINITELY needed.
| const presignedUrlForProjectCode = await getPresignedURLForProjectCodePush(region, name, stage); | ||
| return uploadContentToS3( |
There was a problem hiding this comment.
All temporary folders are already deleted at process exit:
Line 40 in a5e3ea5
| return; | ||
| } | ||
|
|
||
| const paths: CreateFrontendV2Path[] = files.map((file) => ({ |
There was a problem hiding this comment.
What if there are more than 250 files? 😥
There was a problem hiding this comment.
We cry. I'll add a task for this.
Pull Request Template
Type of change
Description
Add CDN support for Nuxt.
Checklist