Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements and fixes on services #1346

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Conversation

andreia-oca
Copy link
Member

@andreia-oca andreia-oca commented Aug 28, 2024

Pull Request Template

Type of change

  • ๐Ÿ• New feature
  • ๐Ÿ› Bug Fix
  • ๐Ÿ”ฅ Breaking change
  • ๐Ÿง‘โ€๐Ÿ’ป Improvement
  • ๐Ÿ“ Documentation Update

Description

This PR:

  • Improves genezio local DX with logs and a question
  • Updates the authentication providers if they changed in the genezio.yaml.
  • Throws an error if project/authentication is not set, but ${{services.authentication.token/region}} is used
  • Removes old parsing methods for variables and replace them with evaluateResource.

Checklist

  • My code follows the contributor guidelines of this project;
  • I have updated the documentation;
  • I have added tests;
  • New and existing unit tests pass locally with my changes;

Base automatically changed from add-auth-email-templates to dev August 28, 2024 09:53
Signed-off-by: Andreia Ocฤƒnoaia <andreia.ocanoaia@gmail.com>
Signed-off-by: Andreia Ocฤƒnoaia <andreia.ocanoaia@gmail.com>
Signed-off-by: Andreia Ocฤƒnoaia <andreia.ocanoaia@gmail.com>
@andreia-oca andreia-oca changed the title Small improvements and fixes Small improvements and fixes on services Aug 28, 2024
@andreia-oca andreia-oca merged commit e266232 into dev Aug 28, 2024
5 checks passed
@andreia-oca andreia-oca deleted the small-improvements-and-fixes branch August 28, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant