Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support gutter by @gutter and flexgrid kwarg gutter #273

Merged
merged 8 commits into from
Apr 22, 2024
Merged

Conversation

hhaensel
Copy link
Member

Support Quasar's q-gutter / q-col-gutter by adding three new flexgrid kwargs gutter, xgutter and ygutter.
Depeneding on whether the element is a container (rowor column) it chooses the correct gutter setting in class:

julia> row(gutter = :md, @gutter [
         card("Hello", sm = 12, lg = 4)
         card("World", sm = 12, md = 8)
       ]) |> prettify |> println
<div class="row col q-col-gutter-md">
    <div class="col col-sm-12 col-lg-4">
        <q-card>
            Hello
        </q-card>
    </div>
    <div class="col col-sm-12 col-md-8">
        <q-card>
            World
        </q-card>
    </div>
</div>

or

julia> htmldiv(@gutter :md [
                card("Hello", sm = 12, lg = 4)
                card("World", sm = 12, md = 8)
              ]) |> prettify |> println
<div class="q-gutter-md">
    <div class="col-sm-12 col-lg-4">
        <q-card>
            Hello
        </q-card>
    </div>
    <div class="col-sm-12 col-md-8">
        <q-card>
            World
        </q-card>
    </div>
</div>

@hhaensel
Copy link
Member Author

Didn't add tests yet. But this is a working PR, finally!

@hhaensel
Copy link
Member Author

Shall we do a squash and merge?

@hhaensel hhaensel merged commit 651dfd0 into master Apr 22, 2024
14 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant