Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change schema to accept multiValues contact points with repeating subfields #51

Conversation

a-nayden
Copy link
Contributor

changes to complete GenomicDataInfrastructure/gdi-userportal-ckanext-fairdatapoint#21
CKAN scheme: add contact_point field with nested repeating subfields
Solr scheme: allow multiple values for contact_point
plugin: convert contact_point objects to jsonld to avoid solr errors (see docs https://github.com/ckan/ckanext-scheming/tree/master?tab=readme-ov-file#repeating_subfields)

Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@brunopacheco1 brunopacheco1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those changes. It would be really great if you could also implement some test cases, like you did for ckanext-fairdatapoint.

@a-nayden a-nayden merged commit bfccbf9 into main May 23, 2024
2 checks passed
@a-nayden a-nayden deleted the SRP-396-harvester-ckan-scheming-allow-multiple-values-for-contact-point branch May 23, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants