Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scheming): added Dutch translation to all fields for the Scheming #91

Merged

Conversation

Markus92
Copy link
Contributor

@Markus92 Markus92 commented Sep 9, 2024

This PR adds Dutch translation to all scheming fields.

Hopefully will also translate the search facets when we run CKAN with Dutch locale.

Summary by Sourcery

Introduce Dutch translations for all fields in the scheming schema to support multilingual capabilities, potentially improving user experience for Dutch-speaking users.

New Features:

  • Add Dutch translations to all fields in the scheming schema, enhancing multilingual support.

@Markus92 Markus92 marked this pull request as ready for review September 9, 2024 15:07
Copy link
Contributor

sourcery-ai bot commented Sep 9, 2024

Reviewer's Guide by Sourcery

This pull request adds Dutch translations to all fields in the Scheming schema for the GDI User Portal. The changes are implemented by modifying the JSON structure to include both English ('en') and Dutch ('nl') translations for various field labels, help texts, and other textual content throughout the schema.

File-Level Changes

Change Details Files
Added Dutch translations for all field labels and help texts
  • Converted single-language strings to objects with 'en' and 'nl' keys
  • Translated all English text to Dutch for 'nl' entries
  • Updated structure for fields with nested properties to include translations
  • Added Dutch translations for dataset fields, resource fields, and their respective properties
ckanext/gdi_userportal/scheming/schemas/gdi_userportal.json
Updated JSON structure to support multilingual content
  • Modified simple string values to objects with language keys
  • Adjusted nested field structures to accommodate translations
  • Ensured consistency in the new multilingual format throughout the schema
ckanext/gdi_userportal/scheming/schemas/gdi_userportal.json

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

sonarcloud bot commented Sep 9, 2024

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Markus92 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@Markus92
Copy link
Contributor Author

Review comments are about things not currently supported by CKAN, AFAIK.

@hcvdwerf hcvdwerf merged commit a97a769 into GenomicDataInfrastructure:main Sep 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants