Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature Request] Zoom Slider on top of Scrcpy window, next to device name #2119

Open
rdlf4 opened this issue Feb 14, 2021 · 1 comment

Comments

@rdlf4
Copy link

rdlf4 commented Feb 14, 2021

  • [ OK] I have checked that a similar feature request does not already exist.

Is your feature request related to a problem? Please describe.
It's a little frustrating to read my Kindle ebooks using the zoom feature. The reason for that is this: It is never clear or predictable what the output will be. I mean, when holding CTRL and dragging the mouse button down, it was supposed to zoom out, and the opposite to zoom in. But that hasn't been the case, at least to my experience, according to the case I initially mentioned. Same goes for viewing photos and zooming in or out when using Scrcpy.

Describe the solution you'd like
With a physical, visible option such as a slider, one could make sure the output is as requested.
Take the attached picture as an example. Upon being launched, the slider would sit on the zero (normal view) position.
When sliding it to the right (positive value), it will always zoom in to the max, 100% (the positive [+] end);
And when sliding to the left of the initial zero position, Scrcpy will now zoom down to -100% (the negative [-] end of the slider).
scrcpy_sugg01
That visual representation and manual control would solve all the issues I've been having with Scrcpy (in regards to the zoom feature, obviously).

Additional context
As far as I can tell, the existing zooming feature is good, but there's room for improvement.
Currently, when holding down CTRL (Win, Linux) and dragging the mouse button all the way down, there's an imaginary line the software will follow to determine the limits to zoom in and out. The control I'm suggesting puts and end to that and visually represents exactly what is happening.

Dev, please consider this suggestion to better handle the zoom feature.
Keep up the great work!

@rom1v
Copy link
Collaborator

rom1v commented Feb 14, 2021

Hi,

The reason the "zoom" feature is implemented that way is that it generates "mirrored" touch events relative to the center of the screen: #24 (comment)

An additional feature to simulate touch events with something like Ctrl+scroll would also be great, but it's not trivial.

(a slider in the menu bar would require CSD, which is not possible with SDL, and a widget, also not available in SDL, so that would probably not be implemented that way)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants