-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shift was tranferred to the device in an old version (aug 18), then no more #879
Comments
The shift key have never been forwarded directly to the device. Here is the code of v1.0:
Text is sent as text, not as a combination of key events: https://blog.rom1v.com/2018/03/introducing-scrcpy/#handle-text-input So, when you press If it does not work, what do you observe exactly? |
shift+a = a |
OK, so this is related to #87 (comment). Since this commit, letters are sent as raw key events (including their modifiers like shift) instead of as text. However, they include the modifiers, so shift should be taken into account. What is the keyboard layout on your device and on your computer? If you apply this patch, build, run, and press diff --git a/app/src/event_converter.c b/app/src/event_converter.c
index da4b2e3..65e6075 100644
--- a/app/src/event_converter.c
+++ b/app/src/event_converter.c
@@ -1,6 +1,7 @@
#include "event_converter.h"
#include "config.h"
+#include "log.h"
#define MAP(FROM, TO) case FROM: *to = TO; return true
#define FAIL default: return false
@@ -172,6 +173,11 @@ convert_input_key(const SDL_KeyboardEvent *from, struct control_msg *to) {
}
to->inject_keycode.metastate = convert_meta_state(mod);
+ LOGD("key (action=%x): %x [mod=%x, metastate=%x]",
+ (int) from->type,
+ (int) from->keysym.sym,
+ (int) from->keysym.mod,
+ (int) to->inject_keycode.metastate);
return true;
} |
I have Italian kbd on Win10... so I can't rebuild |
Does |
Shift is forwarded to the device since v1.15 (d4ca85d). |
Or is there an option I haven't seen?
Using shift makes writing uppercase letters a lot easier
The text was updated successfully, but these errors were encountered: