fix: fix CleanUp classpath bug

[sam80180]

no need to fix compiled artifact's name to '/data/local/tmp/scrcpy-server.jar'

[rom1v]

This is an idea, but the classpath will not necessary contains only the scrcpy-server jar to cleanup. For example, we might add other jars in the classpath: #3927 (comment)

[sam80180]

I tried to use DexClassLoader to solve the problem.

[rom1v]

Thank you. I took your commit and simplified (by making assumptions): e76ff25 (on PR #4446, it simplified a lot my work because now the scrcpy-server jar name is random on the device).

[sam80180]

if scrcpy is not the first item in CLASSPATH, you code just doesn't work. Better not make such assumption, as CLASSPATH order is up to users.

[rom1v]

scrcpy is not the first item in CLASSPATH, you code just doesn't work.

There are only two cases:

• scrcpy-server.jar is the only item in the classpath
• in Fix turn screen off on Android 14 #4446, a new process is run with 2 items, scrcpy-server.jar being first.

Therefore, running more complex code handling any order, with relative or absolute paths, opening jar files and iterating over all the classes (internally) is unnecessary: more runtime execution (probably negligible) and more risk of bugs (on any custom ROM). If the server path cannot be determined, that would make scrcpy fail.

Better not make such assumption, as CLASSPATH order is up to users.

The server is intended to work with the scrcpy client, it is not a generic library. Although there are some features which facilitate its use without the scrcpy client, its design is not constrained by other use cases.

https://github.com/Genymobile/scrcpy/blob/master/doc/develop.md#standalone-server

That's why hardcoding the path was ok until I added randomness to the path name.

[rom1v]

I merged this commit into dev: acb2988. If we need more complex detection later, we can still modify it.