Upgraded Jekyll version utilized in Dockerfile #41
Conversation
|
I didn't merge using an issue, that was my bad, going to do so for Kepler.gl integration. |
| @@ -1,7 +1,7 @@ | |||
| # Pull down a Jekyll base image (which uses ruby:2.7.1-alpine3.11) | |||
|
|
|||
| # dev-stage | |||
| FROM jekyll/jekyll:4.0 | |||
| FROM jekyll/jekyll:4.2.2 | |||
There was a problem hiding this comment.
@dpeachpeach Did you try it on Apple M1? It seems not working correctly on arm64. Thanks!
|
@dpeachpeach I can't get local dev working with docker. Instead, I just upgraded gulp to v4, so with node v12, one can run local dev using Let me know what you think. Thanks! |
| "url": "https://github.com/GeoDaCenter/data-and-lab.git" | ||
| }, | ||
| "volta": { | ||
| "node": "12.22.12" |
There was a problem hiding this comment.
You can use volta or nvm to pin a specific node version
There was a problem hiding this comment.
You can merge it once you verify it on your side. Thanks, @dpeachpeach !
|
Thanks Xun! I'm going to verify it right now |
|
@dpeachpeach If everything works as expected, you can click the green "Squash and merge" button. Thanks! |
Successfully served data-and-lab locally. I looked for opportunities to upgrade Jekyll where I could and only saw an improvement I could make in the Dockerfile.
Something I have a question about is the way data-and-lab runs without utilizing a Gemfile (All the docs I found online stated that a gemfile was essential and in the practice jekyll website I made I utilized a gemfile).
Kepler.Gl integration next.