Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: using kepler.gl to replace leaflet map #42

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Conversation

lixun910
Copy link
Member

@lixun910 lixun910 commented Jul 27, 2023

  • move the react + webpack code to keplermap/ test_kepler.zip
  • copy and reconfig the webpack.config.js
  • update the js libraries and the package.json

The target is to prebuild the react component for mapping first and the output will be in asserts/js/webglmap.js

  • replace the old leaflet code in each post with the new
  • update the CSS style to match our site

_posts/2020-09-11-airbnb.md Outdated Show resolved Hide resolved
@lixun910
Copy link
Member Author

@dpeachpeach Hi David, this is the react project to create the bundle.js
test_kepler.zip

@lixun910 lixun910 mentioned this pull request Aug 1, 2023
@lixun910
Copy link
Member Author

lixun910 commented Aug 1, 2023

@dpeachpeach See the list of tasks above. Thanks!

  • move the react + webpack code to keplermap/ test_kepler.zip
  • copy and reconfig the webpack.config.js
  • update the js libraries and the package.json

The target is to prebuild the react component for mapping first and the output will be in asserts/js/webglmap.js

  • replace the old leaflet code in each post with the new
  • update the CSS style to match our site

@lixun910
Copy link
Member Author

lixun910 commented Aug 1, 2023

@dpeachpeach check out this branch feat-webgl-map, run jekyll serve and you should be able to see the kepler.gl map running in the first AirBnB data page.

@dpeachpeach
Copy link
Contributor

yep! @lixun910 I'm integrating kepler gl into the other markdown files

@dpeachpeach
Copy link
Contributor

Hey @lixun910 I tested everything on my end locally and it works ok. Fixed some styling issues. I couldn't get building to work locally so everything in the map itself style-wise is the same but I'm hoping i can solve that sometime after today. Let me know if everything looks good

@lixun910
Copy link
Member Author

lixun910 commented Aug 3, 2023

For conflicting files, you can rebase main branch into your current branch (see instructions here)

@lixun910
Copy link
Member Author

lixun910 commented Aug 3, 2023

@dpeachpeach
Copy link
Contributor

Hey @lixun910 , after I resolve the conflict should I merge? Or should I commit the changes I made with integrating react-geoda

@lixun910
Copy link
Member Author

lixun910 commented Aug 7, 2023

Hey @lixun910 , after I resolve the conflict should I merge? Or should I commit the changes I made with integrating react-geoda

@dpeachpeach Thanks David! You can solve the conflict first, then you can commit the changes integrating react-geoda. Then, merge the PR after I review it :)

@dpeachpeach dpeachpeach linked an issue Sep 1, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integrate reactgeoda submodule + script
2 participants