Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash: grouped variables + Conditional plots #1795

Closed
Ashitacarl opened this issue Jan 8, 2019 · 7 comments
Closed

Crash: grouped variables + Conditional plots #1795

Ashitacarl opened this issue Jan 8, 2019 · 7 comments
Assignees
Labels

Comments

@Ashitacarl
Copy link

GeoDa 1.12.1.183 (macOS Mojave, 10.14.1). Dec. 19 build.

Data used: NYC sample data; External data w and w/o missing values.

After creating grouped variables in time editor, GeoDa crashes instantly when implementing conditional plots (maps/histograms/scatter plots). No crash for all other plots (box plot, histogram scatter matrix etc). Similar to an old issue #1228

Warning message (clicking any of the three options causes crash):

1795

@Ashitacarl Ashitacarl added the bug label Jan 8, 2019
@lixun910
Copy link
Member

lixun910 commented Jan 9, 2019

@Ashitacarl Thank you! Can you give me more specific steps to replicate this crash?

@Ashitacarl
Copy link
Author

@lixun910 Sure!

  1. Open NYC data;
  2. Time editor > create group variables (e.g., forhis06 - forhist09);
  3. Leave time editor open;
  4. Clicking conditional plot (either of map/scatter plot/histogram) leads to crash.

If time editor is closed after creating the group variable, there is no crash.

1796-2

@lixun910
Copy link
Member

@Ashitacarl Can you help to verify a fix using V185? Thanks!
https://www.dropbox.com/s/w80gr3jboslgsn1/GeoDa1.12.1.185-Installer.dmg?dl=0

@Ashitacarl
Copy link
Author

GeoDa 1.12.1.185 (macOS Mojave, 10.14.1). Jan. 9 build.

The same problem persists.

1795-3

lixun910 added a commit to lixun910/geoda that referenced this issue Jan 11, 2019
This is an old bug that caused by incorrect xrc labeling
lixun910 added a commit to lixun910/geoda that referenced this issue Jan 11, 2019
@jkoschinsky jkoschinsky assigned lixun910 and unassigned Ashitacarl Jan 11, 2019
@lixun910
Copy link
Member

@Ashitacarl can you help to verify the fix using this new V185? Thanks!
https://www.dropbox.com/s/w80gr3jboslgsn1/GeoDa1.12.1.185-Installer.dmg?dl=0

@Ashitacarl
Copy link
Author

GeoDa 1.12.1.185 (macOS Mojave, 10.14.1). Jan. 11 build.

Fix verified for Group Variable + Conditional Map and Conditional Histogram.
The problem persists for Conditional Scatter Plot.

Relatedly. In the conditional histogram dialog, we cannot select the time period. See below.

1795-4

lixun910 added a commit to lixun910/geoda that referenced this issue Jan 12, 2019
Crash: grouped variables + Conditional plots GeoDaCenter#1795
lixun910 added a commit to lixun910/geoda that referenced this issue Jan 12, 2019
Crash: grouped variables + Conditional plots GeoDaCenter#1795
@Ashitacarl
Copy link
Author

GeoDa 1.12.1.187 (macOS Mojave, 10.14.1). Jan. 11 build.

Fix verified for Group Variable + Conditional Scatter Plot (and also tested conditional histogram/map).
No crash observed.

Fix verified for variable setting dialog in conditional histogram. It now allows selection of different time period for group variables.

1795-5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants