Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table merge bug: integers with commas are cut off #1898

Closed
jkoschinsky opened this issue Jun 15, 2019 · 2 comments
Closed

Table merge bug: integers with commas are cut off #1898

jkoschinsky opened this issue Jun 15, 2019 · 2 comments
Assignees
@lixun910
Labels
bug fixed: verify! Module-Table

Comments

@jkoschinsky
Copy link
Collaborator

jkoschinsky commented Jun 15, 2019 •
edited

Just came across this bug (Geoda 1.12.1.239 on Moac OSX).

Steps:

  1. Merge table to shapefile

Problem:
when table has integers with commas, e.g. 153,084 or 44,263 (see right side of table in image below), GeoDa imports them as 153 and 44 (see left image below), i.e. it truncates the integer at the comma.

bug
lixun910 added a commit to lixun910/geoda that referenced this issue Jun 16, 2019
@lixun910
Update OGRColumn.cpp
326059a 
Table merge bug: integers with commas are cut off GeoDaCenter#1898
lixun910 added a commit to lixun910/geoda that referenced this issue Jun 16, 2019
@lixun910
GeoDaCenter#1898 update fix with testing on merging feature
1bec812 
note: the merge process cant recognize the field type, and user need to manually change the filed type after merge.With this fix, GeoDa should recognize thr thousand separator and decimal separator, which can be setup manually using OS's system setting dialog, or change GeoDa's language (e.g. Spanish -- using comma as decimal separator).

ready to build
lixun910 added a commit to lixun910/geoda that referenced this issue Jun 17, 2019
@lixun910
update fix of GeoDaCenter#1898
6cc7169 
Also fix another bug that when edit cell in table (only when using sqlite data source), the double precision value will be rounded to an integer number in the editing box.
@lixun910 lixun910 mentioned this issue Jun 18, 2019
Merged
@lixun910
Copy link
Member

lixun910 commented Aug 2, 2019 •
edited

Fix verified.
image
image

@lixun910 lixun910 closed this as completed Aug 2, 2019
@lixun910
Copy link
Member

lixun910 commented Aug 2, 2019

Using menu item: table->Setup Number Formatting, one can specify the thousand separator and decimal separator manually. For example, if you set “,” to be the decimal separator. Then, the case: 45,128 will be converted to 45.128 (double type) or 45 (integer type).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lixun910 lixun910

Labels
bug fixed: verify! Module-Table
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lixun910 @jkoschinsky