Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename time variable in DID regression output #440

Closed
jkoschinsky opened this issue May 25, 2016 · 6 comments
Closed

Rename time variable in DID regression output #440

jkoschinsky opened this issue May 25, 2016 · 6 comments

Comments

@jkoschinsky
Copy link
Collaborator

Right now, because we only name the time variable TIME_PERIOD, you can't tell which time period is 0 and 1. Instead of TIME_PERIOD, could you use the variable name from the space-time table where the time dummy = 1, e.g. T_2010?

screen shot 2016-05-25 at 1 54 49 pm

@lixun910
Copy link
Member

In DID, the two time periods are stacked.

So, that's why we use "TIME_PERIOD", and can't pick just one time variable name.

Am I right?

@lanselin
Copy link
Collaborator

yes, they are stacked, but somehow there has to be intelligence there that knows which time period it is. for example, with the table export function it would have to know which time period to pick. alternatively, we can call it TIME_2, which is always later than whatever the base time is.

@jkoschinsky
Copy link
Collaborator Author

Users currently set Period 1 and Period 2 in the averages tool interface
based on the drop-down options that correspond to the labels set in the
space-time table.
Period 1 = 0 and Period 2 = 1. We do have that logic in there now but if
someone specifies a later time as Period 1 and the earlier one as Period 2,
then there's no way to trace this right now.

On 25 May 2016 at 14:55, Luc Anselin notifications@github.com wrote:

yes, they are stacked, but somehow there has to be intelligence there that
knows which time period it is. for example, with the table export function
it would have to know which time period to pick. alternatively, we can call
it TIME_2, which is always later than whatever the base time is.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#440 (comment)


Julia Koschinsky, Ph.D.
Research Director
Associate Research Professor
Arizona State University
School of Geographical Sciences and Urban Planning
GeoDa Center for Geospatial Analysis and Computation
julia.koschinsky@asu.edu

http://geodacenter.asu.edu
http://www.facebook.com/geodacenter
http://twitter.com/GeoDaCenter

@lanselin
Copy link
Collaborator

I think the interface should not allow period 1 to be "after" period 2. that doesn't make sense.

lixun910 referenced this issue in lixun910/geoda May 27, 2016
lixun910 referenced this issue in lixun910/geoda May 27, 2016
if compare e.g. 1970 with 1990, the the var name of Time Variable
becomes “T1970_1990”
@jkoschinsky
Copy link
Collaborator Author

Verified in GeoDa 1.8.7.9 (OSX Yosemite, 10.10.5).

The time label in the regression works great now.

The T2 > T1 mostly works but there are some instances when you can get T2 before T1, e.g.

  1. Select new time grouped variable
  2. Group 1 and 2 unselected
  3. T1 = 2010, T2 = 1990:

screen shot 2016-05-31 at 11 15 52 am

If this is easy to fix, let's do it. Otherwise, since the regression label then updates to T2010_1990, people at least know now what the order is.

@jkoschinsky
Copy link
Collaborator Author

Verified in GeoDa 1.8.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants