Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata Change information tabs #95

Merged
merged 12 commits into from
Feb 22, 2022
Merged

Metadata Change information tabs #95

merged 12 commits into from
Feb 22, 2022

Conversation

salichon
Copy link
Contributor

  • Documentation for Users to follow up with metadata changes.
  • Update on the SM Obsidian 4X datalogger correction as per 17 Feb 2022

@salichon salichon self-assigned this Feb 21, 2022
mnaguit
mnaguit approved these changes Feb 21, 2022
View reviewed changes
Copy link

@mnaguit mnaguit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @salichon .
Many thanks. 👍

@elidana
Copy link
Contributor

elidana commented Feb 21, 2022

nice!

Thanks @salichon!

A couple of minor suggestions from me:

  • change the filename to something more specific (you can have other "metadata-correction" coming along in the future. Something like "obsidian-response-file" (or shorter)
  • add a bit more context in the file explanation: what has been corrected, a link to the delta pull request that fixed it, and what is the likely impact (i.e. gain*4) on derived products

@salichon salichon mentioned this pull request Feb 21, 2022
Closed
@salichon salichon removed the bug label Feb 21, 2022
salichon and others added 6 commits February 22, 2022 09:26
@salichon
formating
5e426b5
@salichon
Formatting II
fd1024a
@salichon
still formatting
1870899
@salichon
formatting .....
a44b0bc
@elidana
update readme file
de877ec 
Hi @salichon ,

I added some minor tweaks to the readme to make it a bit more general, and will add the more detailed info in the dedicated file
@elidana
Update strongmotion_obsidian4x_response.md
479f0bd 
Hi Jerome, did some minor reformatting and added a couple of sentences . Hope you agree with those, but please update anything that you think is wrong!
elidana
elidana approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@elidana elidana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @salichon !!
THanks heaps for preparing this! I did a couple of further very minor tweaks and committed (hope is ok with you).

Feel free to squash all commits into one and merge when you're happy!
THANKS HEAPS (also to @ozym and C.Burton that worked with you to fix this nasty little beast)

@salichon salichon merged commit 3b4da44 into GeoNet:main Feb 22, 2022
@salichon salichon deleted the MetaChanges branch February 22, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnaguit mnaguit mnaguit approved these changes

@elidana elidana elidana approved these changes

Assignees

@salichon salichon

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@salichon @elidana @mnaguit