Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #11883] the extent values should now only include decimal separator #11884

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

ahmdthr
Copy link
Contributor

@ahmdthr ahmdthr commented Jan 23, 2024

Fixes issue#11883, the extent values should now only include decimal separator whichever language is selected.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in ISO metadata includes commas in the extent segment for European languages #11883 describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Merging #11884 (4f47ebb) into master (e68d8c5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11884   +/-   ##
=======================================
  Coverage   63.04%   63.04%           
=======================================
  Files         877      877           
  Lines       52655    52655           
  Branches     6616     6616           
=======================================
  Hits        33198    33198           
  Misses      17937    17937           
  Partials     1520     1520           

@mattiagiupponi mattiagiupponi changed the title Fixes issue#11883, the extent values should now only include decimal separator [Fixes #11883] the extent values should now only include decimal separator Feb 2, 2024
@giohappy giohappy added this to the 4.3.0 milestone Feb 2, 2024
@giohappy giohappy merged commit 54059ce into GeoNode:master Feb 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISO metadata includes commas in the extent segment for European languages
2 participants