Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #5429] Layer feature info templates are not used inside maps #5430

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

afabiani
Copy link
Member

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there are explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@afabiani afabiani added this to the 2.10.2 milestone Dec 17, 2019
@afabiani afabiani self-assigned this Dec 17, 2019
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Dec 17, 2019
@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #5430 into master will increase coverage by 0.04%.
The diff coverage is 51.72%.

@@            Coverage Diff             @@
##           master    #5430      +/-   ##
==========================================
+ Coverage   57.53%   57.57%   +0.04%     
==========================================
  Files         172      172              
  Lines       19280    19299      +19     
  Branches     3000     3006       +6     
==========================================
+ Hits        11092    11112      +20     
+ Misses       7168     7167       -1     
  Partials     1020     1020

@afabiani afabiani merged commit d449dc5 into master Dec 18, 2019
afabiani pushed a commit that referenced this pull request Dec 18, 2019
[Fixes #5429] Layer feature info templates are not used inside maps

(cherry picked from commit d449dc5)
@afabiani afabiani deleted the ISSUE_5429 branch December 18, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layer feature info templates are not used inside maps
2 participants