Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD : ruleset file #1

Merged
merged 1 commit into from
Oct 25, 2017
Merged

ADD : ruleset file #1

merged 1 commit into from
Oct 25, 2017

Conversation

ektarum
Copy link
Contributor

@ektarum ektarum commented Oct 24, 2017

No description provided.

@ektarum ektarum requested a review from devster October 24, 2017 14:39
@ektarum ektarum force-pushed the geolid-rule branch 11 times, most recently from 4164228 to 5730594 Compare October 25, 2017 13:25
README.md Outdated
- trailling comma : multiline arrays must have comma in all line
- no more 3 nesting identation levels
- minimal length of naming (function, variable, constant...) is 3 chars (except for i, id, em, om, to, ID, TO)
- object instantiation must always be with parentheses
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: instanciation

Copy link
Contributor Author

@ektarum ektarum Oct 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

en anglais il y a bien un t et pas un c

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on peut s'organiser des cours d'anglais le vendredi après midi, non ?

README.md Outdated

## Description

We follow the PSR-2 coding style with additionnal rules.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo additional

README.md Outdated
- private methods and properties MUST not be prefixed with an underscore
- one space around concatenation operator
- array must be in short syntax
- trailling comma : multiline arrays must have comma in all line

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo trailing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants