Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(InstanceAccount): do not increase the notification counter on excluded types #1014

Merged

Conversation

GeopJr
Copy link
Owner

@GeopJr GeopJr commented Jun 19, 2024

fix: #995 (comment) (partially)

The issues with counting still apply:

Agreed, though I don't think I can completely get rid of it. The way marking notifications as read works, is by setting a 'marker' to the last read notification. So, while I can avoid increasing the count when Tuba received a filtered notification type, it won't be able to do it if the marker increased while offline. E.g. You make a post and close Tuba. All notification have been read. While offline, you get 10 favourites. When you re-open Tuba the marker will be less than the last notification id, so now there are 10 unread notifications you can't see because they are filtered...

But now, if Tuba, while running, receives an excluded notification, it won't increase the counter.

Internally, it will still count it, as in, it will mark it as read when opening the notifications tab

@GeopJr GeopJr merged commit 6fd5d72 into main Jun 19, 2024
5 checks passed
@GeopJr GeopJr deleted the feat/instanceaccount/notification-counter-excluded-types branch June 19, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant