feat(Entity): OOP-ify the array deserialization mess #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will make adding more properties easier in the future
API.Poll has always been the odd one out as it doesn't inherit from Entity and Widgetizable but implemented its deserialization manually
GeopJr
deleted the
feat/entity/oop-ify-the-array-deserialization-mess
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArrayList deserialization from JSON has been very messy. There's a huge switch statement that goes through each possible property name to find the type. Not only is that unmaintainable but also leads to property conflicts:
For example an entity that has an
uploadsproperty of string and an entity that also has anuploadsproperty but of API.Attachment cannot co-exist. We've been lucky so far that there haven't been any conflicts.This PR creates a virtual function that returns a
Typefor a property name, allowing descendants to override it for their needs.