Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use copy icon for copying handle #617

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Use copy icon for copying handle #617

merged 1 commit into from
Oct 24, 2023

Conversation

kra-mo
Copy link
Contributor

@kra-mo kra-mo commented Oct 24, 2023

The share icon is more commonly associated with opening a share sheet and with no visual feedback of a successful copy, it can look like the button did nothing.

Ideally, the copy action would display a toast too.

The share icon is more commonly associated with opening a share sheet and with no visual feedback of a successful copy, it can look like the button did nothing.

Ideally, the copy action would display a toast too.
@GeopJr
Copy link
Owner

GeopJr commented Oct 24, 2023

LGTM, thanks!
I'll open another issue for feedback toasts

@GeopJr GeopJr merged commit cbf10b3 into GeopJr:main Oct 24, 2023
@GeopJr GeopJr mentioned this pull request Oct 24, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants