Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: abstract cache #957

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: abstract cache #957

wants to merge 1 commit into from

Conversation

GeopJr
Copy link
Owner

@GeopJr GeopJr commented May 26, 2024

⚠️ WIP

Mostly discussed on #954

Bringing back the classic in-memory cache.

Benefits:

  • Avoid creating multiple paintables of the same image, lowering ram usage
  • Avoid processing already processed images

TODO:

  • Add a "dont cache" option. We really don't want to cache profile pics/banners. They change but the url stays the same, let libsoup handle their caching
  • Combine with feat(emoji): libsoup cache lookup #915
  • Increase maintenance timeout to probably 1 minute?
  • Use url hashes instead (same as feat(emoji): libsoup cache lookup #915)
  • More testing on the media viewer... maybe let libsoup handle that?
  • A way to update paintables so race conditions / updates don't break existing ones? Or maybe not inserting if it exists already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant