Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement for equal X and Y resolution in conv2tif #306

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

mcgarth
Copy link
Contributor

@mcgarth mcgarth commented Oct 26, 2020

This PR removes a long-held rule in conv2tif that the input rasters must have equal X and Y pixel resolutions.

This issue was identified by an external user who has unequal X/Y resolution images - see #305

In this PR I have removed:

  • one check in the function shared.write_fullres_geotiff, used only in conv2tif step
  • the check function associated with the above
  • two tests associated with the check function

@codecov-io
Copy link

Codecov Report

Merging #306 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
- Coverage   83.22%   83.20%   -0.03%     
==========================================
  Files          26       26              
  Lines        3470     3465       -5     
  Branches      544      542       -2     
==========================================
- Hits         2888     2883       -5     
  Misses        486      486              
  Partials       96       96              
Impacted Files Coverage Δ
pyrate/core/shared.py 93.08% <ø> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb4a444...61a7476. Read the comment docs.

@mcgarth mcgarth merged commit 15a3181 into master Oct 27, 2020
@mcgarth mcgarth deleted the mg/res-mismatch branch October 27, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants