Update tests to ignore Markdown, RST and template and landing page notebooks #1194
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,15 +5,19 @@ on: | |
| push: | ||
| branches: [ develop, stable, nbtests ] | ||
| paths-ignore: | ||
| - 'DEA_Sandbox.ipynb' # ignore landing page | ||
| - 'DEA_notebooks_template.ipynb' # ignore template | ||
| - '*.md' # ignore all markdown files | ||
| - '*.rst' # ignore all restructured text files | ||
| - '.github/**' # ignore anything in .github folder | ||
| - '!.github/workflows/test_notebooks.yml' # except test_notebooks.yml | ||
| pull_request: | ||
| branches: [ develop, stable ] | ||
| paths-ignore: | ||
| - 'DEA_Sandbox.ipynb' | ||
|
There was a problem hiding this comment. Are you sure this should be ignored? It is a Notebook file that we need to check renders properly on the Sandbox. There was a problem hiding this comment. It doesn't actually include any code - it's all entirely pre-rendered markdown cells so there's not anything for |
||
| - 'DEA_notebooks_template.ipynb' | ||
| - '*.md' | ||
| - '*.rst' | ||
| - '.github/**' | ||
| - '!.github/workflows/test_notebooks.yml' | ||
|
There was a problem hiding this comment. Maybe we should ignore everything in the root directory except for Notebook files: - '*'
- '!*.ipynb'There was a problem hiding this comment. I'd be happy to ignore all top-level files - the two notebooks there are either entirely Markdown or are not intended to be run by our users (both aren't included in our test coverage anyway, and There was a problem hiding this comment. I agree. Sounds good. |
||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this
**/*syntax is needed to ignore all of them recursively, not just in the root directory.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the recursive ignore was ignoring the top level markdown files in your previous PR - it seemed to be only catching the ones nested within subfolders.
We could leave the recursive ignore as it is though and adding in your suggested top level "*" ignore to catch the Readme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, maybe it just needs to be "**.md?" to catch both top level and nested files?
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#patterns-to-match-file-paths