Add S2 L1 & ARD products #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyh
force-pushed
the
s2-l1
branch
2 times, most recently
from
f43a7fb
to
04126ea
Compare
Fixed validation against the product definition
Now that it's included in newer eod3
... as reported by @uchchwhash. It now passes the `--thorough` check in eo3-validate on the latest dataset examples. (though that check cannot check the flag definition... hopefully they're right?)
Disabled in c7035cd, but we can now ease warnings per-product.
|
Future changes will be separate PRs. I think we're close enough to merge this now. |
|
Hi Jeremy,
This looks good.
Could you push this up to a branch on the main repo so I can suggest some changes?
Cheers
Duncan
…________________________________
From: Jeremy Hooke ***@***.***>
Sent: Friday, 20 May 2022 12:58 PM
To: GeoscienceAustralia/digitalearthau ***@***.***>
Cc: Duncan Gray ***@***.***>; Review requested ***@***.***>
Subject: Re: [GeoscienceAustralia/digitalearthau] Add S2 L1 & ARD products (PR #311)
@jeremyh<https://github.com/jeremyh> requested your review on: #311<#311> Add S2 L1 & ARD products.
—
Reply to this email directly, view it on GitHub<#311 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAIAHKJIEKFPOBBR3EKYX5TVK35T7ANCNFSM5PPXQ73Q>.
You are receiving this because your review was requested.Message ID: ***@***.***>
Geoscience Australia Disclaimer: This e-mail (and files transmitted with it) is intended only for the person or entity to which it is addressed. If you are not the intended recipient, then you have received this e-mail by mistake and any use, dissemination, forwarding, printing or copying of this e-mail and its file attachments is prohibited. The security of emails transmitted cannot be guaranteed; by forwarding or replying to this email, you acknowledge and accept these risks.
|
You should be able to add suggestions here on the PR? Or do you want to push your own commits? |
|
I can't do edits to the code in the PR currently.
I think I would be able to if these changes where on a branch of the main repo.
…________________________________
From: Jeremy Hooke ***@***.***>
Sent: Friday, 20 May 2022 4:16 PM
To: GeoscienceAustralia/digitalearthau ***@***.***>
Cc: Duncan Gray ***@***.***>; Review requested ***@***.***>
Subject: Re: [GeoscienceAustralia/digitalearthau] Add S2 L1 & ARD products (PR #311)
Hi Jeremy, This looks good. Could you push this up to a branch on the main repo so I can suggest some changes? Cheers Duncan
…
You should be able to add suggestions here on the PR? Or do you want to push your own commits?
—
Reply to this email directly, view it on GitHub<#311 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAIAHKP3G5W7IMYWKPSYBHDVK4U4FANCNFSM5PPXQ73Q>.
You are receiving this because your review was requested.Message ID: ***@***.***>
Geoscience Australia Disclaimer: This e-mail (and files transmitted with it) is intended only for the person or entity to which it is addressed. If you are not the intended recipient, then you have received this e-mail by mistake and any use, dissemination, forwarding, printing or copying of this e-mail and its file attachments is prohibited. The security of emails transmitted cannot be guaranteed; by forwarding or replying to this email, you acknowledge and accept these risks.
|
|
Hi Jeremy,
Could you push this up to a branch on the main repo?
Cheers
Duncan
…________________________________
From: Jeremy Hooke ***@***.***>
Sent: Friday, 20 May 2022 4:16 PM
To: GeoscienceAustralia/digitalearthau ***@***.***>
Cc: Duncan Gray ***@***.***>; Review requested ***@***.***>
Subject: Re: [GeoscienceAustralia/digitalearthau] Add S2 L1 & ARD products (PR #311)
Hi Jeremy, This looks good. Could you push this up to a branch on the main repo so I can suggest some changes? Cheers Duncan
…
You should be able to add suggestions here on the PR? Or do you want to push your own commits?
—
Reply to this email directly, view it on GitHub<#311 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAIAHKP3G5W7IMYWKPSYBHDVK4U4FANCNFSM5PPXQ73Q>.
You are receiving this because your review was requested.Message ID: ***@***.***>
Geoscience Australia Disclaimer: This e-mail (and files transmitted with it) is intended only for the person or entity to which it is addressed. If you are not the intended recipient, then you have received this e-mail by mistake and any use, dissemination, forwarding, printing or copying of this e-mail and its file attachments is prohibited. The security of emails transmitted cannot be guaranteed; by forwarding or replying to this email, you acknowledge and accept these risks.
|
dunkgray
approved these changes
May 24, 2022
Co-authored-by: Duncan Gray <duncan.gray@ga.gov.au>
Co-authored-by: Duncan Gray <duncan.gray@ga.gov.au>
Co-authored-by: Duncan Gray <duncan.gray@ga.gov.au>
Co-authored-by: Duncan Gray <duncan.gray@ga.gov.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... used in the s2_test database
This also fixes the previous CI validation warnings, and re-enables the stricter mode of checking that was disabled in c7035cd