Move download functions from ginan/scripts/auto_download_PPP to gnssanalysis #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronaldmaj
approved these changes
Jan 25, 2024
| @@ -306,9 +306,12 @@ def nominal_span_string(span_seconds: float) -> str: | |||
| unit = "W" | |||
| span_unit_counts = int(span_seconds // gn_const.SEC_IN_WEEK) | |||
| elif span_seconds >= gn_const.SEC_IN_WEEK: | |||
| if (span_seconds % gn_const.SEC_IN_WEEK) < gn_const.SEC_IN_DAY: | |||
| num_weeks = int(span_seconds // gn_const.SEC_IN_WEEK) | |||
There was a problem hiding this comment.
This is a good idea, makes things a lot clearer for the if statement that comes next
| @@ -339,6 +345,7 @@ def get_install_crx2rnx(override=False, verbose=False): | |||
| logging.info(f"crx2rnx already present in {_sys.path[0]}") | |||
|
|
|||
|
|
|||
| # TODO: Deprecate in favour of the contextmanager? | |||
There was a problem hiding this comment.
We'll need to check where this is still used and replace it, but yep, I think we can definitely get rid of this after that
| list(executor.map(download_file_from_cddis, files, _repeat(ftp_folder), _repeat(output_folder))) | ||
|
|
||
|
|
||
| # TODO: Deprecate? Only supports legacy filenames |
There was a problem hiding this comment.
Yeah, I think once we have the other functions that allow download_file_from_cddis to carry out the expected file downloads, we can definitely get rid of this.
Other functions here I mean stuff like filename generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Download functions in auto_download_PPP have wider use. Proposing to incorporate into gnssanalysis.