Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPI-3290 Clearer error on empty Sinex header #20

Merged
merged 1 commit into from
May 16, 2024

Conversation

treefern
Copy link
Collaborator

@treefern treefern commented May 6, 2024

Raise a clearer error (referencing the source file if possible) when an empty Sinex header is encountered.

…le) when an empty Sinex header is encountered
@treefern treefern self-assigned this May 6, 2024
@treefern treefern requested a review from ronaldmaj May 6, 2024 02:15
@jashlearn
Copy link
Collaborator

This looks pretty decent. Out of interest do you have an example of a failing file that we can look at? I'm just wondering about the error message. It somehow feels unlikely that we see a header line that contains %=SNX only (which is a true empty header line) compared to a file that is either completely empty or is missing the header and doesn't have %=SNX anywhere. In which case we might want to be doing a test immediately after the search for the start of the header and providing a "missing header" error message at that point.

Copy link
Collaborator

@ronaldmaj ronaldmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice catch for the SNX header - happy for this to go in

@ronaldmaj ronaldmaj merged commit c5e5179 into main May 16, 2024
@treefern treefern deleted the NPI-3290-clearer-error-on-empty-sinex-header branch September 12, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants