Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove url from the db. Making photos public #138

Merged
merged 2 commits into from
Nov 30, 2018
Merged

remove url from the db. Making photos public #138

merged 2 commits into from
Nov 30, 2018

Conversation

sebastianovide
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Nov 30, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 306

  • 2 of 11 (18.18%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 17.374%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/custom/dbFirebase.js 2 11 18.18%
Totals Coverage Status
Change from base Build 304: -0.1%
Covered Lines: 72
Relevant Lines: 372
💛 - Coveralls

@joykuotw joykuotw merged commit e7933d4 into Geovation:master Nov 30, 2018
@sebastianovide sebastianovide deleted the fix_urls_expires branch December 17, 2018 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joykuotw joykuotw joykuotw approved these changes

@kdalkafoukis kdalkafoukis Awaiting requested review from kdalkafoukis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebastianovide @coveralls @joykuotw