workaround to publish also .gitignore #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joykuotw
reviewed
Oct 30, 2018
| @@ -30,7 +30,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "start": "HTTPS=true react-scripts start", | |||
| "build": "react-scripts build && cp -a ./build/. ./cordova-app/www/", | |||
| "build": "react-scripts build && cp -a ./build/. ./cordova-app/www/ && cp .gitignore gitignore", | |||
There was a problem hiding this comment.
Why need to copy to a new gitignore folder?
There was a problem hiding this comment.
it is not a folder: it is a copy of .gitignore. it is a work around as .gitignore is not published.
joykuotw
reviewed
Oct 31, 2018
| @@ -39,7 +39,8 @@ function copySrc() { | |||
| ncp(path.join(geovationPhotoFolder, "src"), "src", errFunc); | |||
| ncp(path.join(geovationPhotoFolder, "cordova-app"), "cordova-app", errFunc); | |||
| ncp(path.join(geovationPhotoFolder, "public"), "public", errFunc); | |||
| ncp(path.join(geovationPhotoFolder, ".gitignore"), ".gitignore", { clobber : false }, errFunc); | |||
| // see https://github.com/atlassubbed/atlas-npm-init/issues/1 | |||
| ncp(path.join(geovationPhotoFolder, "gitignore"), ".gitignore", { clobber : false }, errFunc); | |||
There was a problem hiding this comment.
Why set clobber to false? it means ncp will not overwrite the existing .gitignore file.
There was a problem hiding this comment.
correct... (should we instead. ?.. perhaps using it we'll learn)
There was a problem hiding this comment.
sure, we can leave it for now. I will merge this PR then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.