Wire dependencies before context initialization #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't imagine how someone would have written their code such that this would be a breaking change, but will call this out on the release notes just in case. Thanks for the PR! |
geekdave
added a commit
that referenced
this pull request
Aug 11, 2014
Wire dependencies before context initialization
creynders
added a commit
to creynders/backbone.geppetto
that referenced
this pull request
Aug 12, 2014
mmikeyy
pushed a commit
to mmikeyy/backbone.geppetto
that referenced
this pull request
Sep 25, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #43 call
context#initializelast when instantiating a context.Tests all pass, so I think there should be no problems. However, I suppose this could be a breaking change for some people..?