Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tinyxml2.dll isn't packaged correctly #313

Closed
ccawley2011 opened this issue Jul 19, 2021 · 1 comment
Closed

tinyxml2.dll isn't packaged correctly #313

ccawley2011 opened this issue Jul 19, 2021 · 1 comment
Assignees
@GerbilSoft
Labels
bug FIXED
Milestone
1.8

Comments

@ccawley2011
Copy link
Contributor

In the 1.8 release archive, the 32-bit version of tinyxml2.dll is installed in a "bin" subdirectory, while the 64-bit version is missing. This leads to a crash when attempting to open Windows executables.
@GerbilSoft GerbilSoft mentioned this issue Jul 19, 2021
Closed
@GerbilSoft
Copy link
Owner

I thought I fixed this before. Besides that, it shouldn't outright crash, since it's supposed to be using delay-load, so that's two bugs to fix:

  1. Figure out why it's not using delay-load for TinyXML2.
  2. Fix packaging.

@GerbilSoft GerbilSoft self-assigned this Jul 19, 2021
@GerbilSoft GerbilSoft added the bug label Jul 19, 2021
@GerbilSoft GerbilSoft added this to the 1.8 milestone Jul 19, 2021
GerbilSoft added a commit that referenced this issue Jul 19, 2021
@GerbilSoft
[libromdata] EXEPrivate::addFields_PE_Manifest(): Check for DelayLoad…
97cbf1e 
… here.

Previously, we were checking for DelayLoad in loadWin32ManifestResource().
This doesn't actually work properly because it takes a reference to
XMLDocument, which means XMLDocument must have been constructed prior
to calling loadWin32ManifestResource().

Check for DelayLoad before calling loadWin32ManifestResource().

This fixes the crash reported in #313: tinyxml2.dll isn't packaged correctly
Reported by @ccawley2011.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GerbilSoft GerbilSoft

Labels
bug FIXED
Projects
None yet
Milestone
1.8
Development

No branches or pull requests
2 participants
@GerbilSoft @ccawley2011