Cross-platform support for getting a home directory path #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tested that locally + inside a docker? |
|
@suminb , hi have you tested this? could you screenshot a working example. |
|
I haven't tested this inside a Docker. I'll show a screenshot when I test it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although GerevAI is most likely going to be running on a Linux environment, it would still be nice to be able to run it on other environments such as macOS or Windows for development and/or testing purposes. This can be achieved by simply replacing
/home/{os.getlogin()withPath.home(). I've noticedpathlib.Pathis already in use, so we might as well use it to get the home directory path for the current user.