Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mask 8.2.5 is not compatible with PHP 7.4 #572

Closed
linawolf opened this issue Jul 25, 2023 · 3 comments
Closed

mask 8.2.5 is not compatible with PHP 7.4 #572

linawolf opened this issue Jul 25, 2023 · 3 comments

Comments

@linawolf
Copy link
Contributor

Omitting the variable name in the catch block only became available with PHP 8

https://www.php.net/manual/en/language.exceptions.php

As of PHP 8.0.0, the variable name for a caught exception is optional. If not specified, the [catch](https://www.php.net/manual/en/language.exceptions.php) block will still execute but will not have access to the thrown object.

(1/1) ParseError
syntax error, unexpected ')', expecting '|' or variable (T_VARIABLE)

in /var/www/html/web/typo3conf/ext/mask/Classes/Updates/MigrateContentFields.php line 101
                        $queryBuilder
                            ->select($legacyParentColumnName)
                            ->from('tt_content')
                            ->executeQuery();
                    } catch (InvalidFieldNameException) {
                        // The legacy field does not exist, no update necessary.
                        continue;
                    }
@nhovratov
Copy link
Collaborator

Oh, thanks for the report, will fix asap.

@linawolf
Copy link
Contributor Author

Why not leave it open for others to see until resolved? This just messed up my TYPO3 login while being in a hurry to do core security updates and this slipped in. Already had to issue a warning within my company. as we are updating all over

nhovratov added a commit that referenced this issue Jul 25, 2023
Fixes: #572
(cherry picked from commit 267d874)
@linawolf
Copy link
Contributor Author

Ok, that was quick ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants