-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Field palette configuration is duplicated across content elements with the same field #601
Comments
Hi, this is a known behaviour. This does not cause any harm, so I had no priority to fix this. I know this is not ideal in git diff views. I will have a look if this can be fixed easily. |
In json-split mode it is not necessary to keep all parent palette information of every element in the installation. The current element is sufficient and the array will be merged again when loaded. This was not harmful before, but resulted in changes of every json file which shares this field. Fixes: #601 (cherry picked from commit 6db1849)
I could fix it! Will make a new release on Moday. |
Wow, that was quick! 💪 Thanks a ton for the fix! ❤️ |
No problem, this bothered me myself for some time now. But I wasn't motivated enough to fix it :) Just update to v8.3.7 and save any content element. The json files will be clean afterwards. |
Hi,
I'm not sure if this intentional, a sideffect which can't be bypassed or a bug. Maybe you can help me out here. :)
First: I have the
json-split
option enabled.Szenario:
I have a bunch of mask content elements which are all using the same
tx_mask_link
field. I'm now adding a new content element (or editing an existing one) calledfaq_teaser
which uses the same field but now I want to wrap the field in a palette. Then the following additional config is added in this new content element for thetx_mask_link
field:Now when I edit one of the older content elements which had the
tx_mask_link
as well and save, the exact same above config is added to every content element even though in these content elements the field is not wrapped in a palette.This means I have information about the "faq_teaser" CE in every other content element. And restructuring one content element with palettes might lead to changed configs in every other content element. Also this makes version control reviews and diffs harder to understand.
I thought with the
json-split
option every config is considered self-sufficient.This behavior is also reproducible with the
override_shared_fields
option enabled.Is my understanding incorrect and this is intentional and necessary or did I face a bug here?
TYPO3: v12.4.7
Mask: v8.3.6
The text was updated successfully, but these errors were encountered: