Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline InlineHelper->addIrreToData introduced 8.0.4 results in array becoming an integer #634

Closed
janus-reith opened this issue Jul 9, 2024 · 4 comments

Comments

@janus-reith
Copy link

Some change introduced in 8.0.4 causes the repeating field on Page Templates to not be filled for me anymore

This was probably caused by "[BUGIFX] Streamline InlineHelper->addIrreToData":
c6c80e3

I have a page template "Default":
mask

The backend layout for this still renders fine and I can configure these items on my pages.
Rendering in the frontend however fails.

In versions up to v8.0.3, data.tx_mask_slideritems was an array and I could iterate over the items.
Starting with v8.0.4, data.tx_mask_slideritems became an integer, presumably with the length of array items, 4 in my case.

@janus-reith
Copy link
Author

I just tested with different new values, it seems like for page templates, any kind of field within the repeating field are not actually resolved in the template but the item length is returned.

But since that was introduced in 8.0.3 already and seems like a common usecase, I have the impression that there must be something I'm missing.

@nhovratov
Copy link
Collaborator

@janus-reith Hi, thanks for reporting the issue. You were correct by pinpointing to the commit. It wrongly did an early return, if CType was not set. However, it is only needed for tt_content records.

nhovratov added a commit that referenced this issue Jul 9, 2024
Fixes: #634
(cherry picked from commit 44cc9fc)
@nhovratov
Copy link
Collaborator

But since that was introduced in 8.0.3 already and seems like a common usecase, I have the impression that there must be something I'm missing.

I'm too quite surprised no one raised an issue in 1.5 years. This feature is very niche and even less people use inline relations there. Still, there are so many users it must have caused problems before.

@janus-reith
Copy link
Author

Awesome, works like a charm now - Thanks a lot for the quick fix!

I'm too quite surprised no one raised an issue in 1.5 years. This feature is very niche and even less people use inline relations there. Still, there are so many users it must have caused problems before.

A bit puzzling indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants