eng(supabase): add query supabase transformer tests #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshedor
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
@devj3ns This is great. I agree exposing uri is less ideal, but given the small implementation you've taken to reach it, I think it's OK. The implementation I'm taking in the transformer is a little brittle IMO instead of just using the first-class .eq methods. In future updates, the Supabase team may expose something more programmatic like the JavaScript filters that we could leverage in Dart. For now, I think this covers our use cases.
Could you please get those remaining tests to pass and then I'll merge?
| group('with query', () { | ||
| group('eq', () { | ||
| test('by field', () { | ||
| final query = Query.where('name', 'Jens'); |
tshedor
merged commit e0193dc
into
GetDutchie:supabase-integration
0 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements most of the tests for the
QuerySupabaseTransformer. (There are still some tests missing, where I am currently not sure how to properly implement them.)I added an
agefield to theDemoModelclass to use it for the lt/gt/lte/gte tests.Because the
_uriproperty of thePostgrestBuilderis private and therefore cannot be directly accessed, I created an extension on thePostgrestBuilderwhich returns theURIby using theoverrideSearchParamsmethod. While this works, I am open for suggestions to improving this!