Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(brick_offline_first): add toSupabase method to OfflineFirstSerdes #423

Merged
merged 2 commits into from
Aug 27, 2024
Merged

fix(brick_offline_first): add toSupabase method to OfflineFirstSerdes #423

merged 2 commits into from
Aug 27, 2024

Conversation

devj3ns
Copy link
Contributor

@devj3ns devj3ns commented Aug 27, 2024

This adds the missing toSupabase method to the OfflineFirstSerdes, which is needed to create OfflineFirstSerdes for Supabase.

@devj3ns devj3ns requested a review from tshedor as a code owner August 27, 2024 08:09
@devj3ns devj3ns changed the base branch from main to supabase-integration August 27, 2024 08:10
@devj3ns devj3ns mentioned this pull request Aug 27, 2024
Closed
tshedor
tshedor requested changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@tshedor tshedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devj3ns Could you please merge the upstream branch to resolve those test failures?

@devj3ns
Copy link
Contributor Author

devj3ns commented Aug 27, 2024

@tshedor done ✅

@tshedor tshedor merged commit 989003b into GetDutchie:supabase-integration Aug 27, 2024
2 checks passed
@tshedor tshedor mentioned this pull request Aug 30, 2024
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshedor tshedor tshedor requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devj3ns @tshedor