This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Use appraisal to run specs for prawn0.6.3 and 0.12.0 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… naming of spec assets w/ respect to prawn version
forrest
added a commit
that referenced
this pull request
Feb 1, 2012
Merging @rylwin's changes to allow a wider range of prawn versions.
|
Excellent. Good thinking with appraisal. Thanks for the help. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for the work you did bringing prawnto up to date!
The tests were failing when using prawn 0.6.3 because the PDFs that are generated, though they look the same, are different at the byte level. I use appraisal to support testing for different versions of prawn and included instructions for how to run the tests in the README.
In generated new PDFs from the dummy app using prawn 0.6.3 and stored them in spec/assets. I used the following naming scheme for all assets: "#{base_file_name}-#{prawn_version}.pdf". I added a method #asset_path in spec_helper.rb that the specs call to generate the asset path for the given version of prawn being used.