-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Suppress from Nav #28
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot have a section automatically appear in the site nav. I know it bugs the heck out of me.
naomiaro
reviewed
Apr 2, 2019
naomiaro
reviewed
Apr 2, 2019
naomiaro
reviewed
Apr 2, 2019
naomiaro
requested changes
Apr 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments above
…-from-nav Updating my branch to fit with master
… the supress logic
…to feat/suppress-from-nav Not sure why this merge is neccessary but apprently it is
…tion to all other article types
naomiaro
reviewed
Apr 26, 2019
naomiaro
reviewed
Apr 26, 2019
… types as well as reversed the logic from being reliant on in_nav to suppress to that a true return makes sense.
naomiaro
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a checkbox which will allow user to not have a section automatically appear in the site nav. I know it bugs the heck out of me.