Fixes #132: Nontermination when using datatypeNameModifier with recursive data types #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code seems to check whether the type is really a type constructor thus starting with an upper case letter. The problem is that this check is done on the transformed name of the type, which may no longer be an upper case letter (e.g. when one uses camelTo2 '_'). Therefore, the check should be done on the original name of the type, which then fixes issue GetShopTV#132.
|
Could you add an regression test? |
Without the fix of GetShopTV#132, the added testcase causes nontermination. With the fix, the tests are all green.
|
I've added a variant of the MyRoseTree testcases. It should cover the problem and fix pretty well. |
|
Nice fix! Thanks @amiddelk 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code seems to check whether the type is really a
type constructor thus starting with an upper case letter.
The problem is that this check is done on the transformed name
of the type, which may no longer be an upper case letter
(e.g. when one uses camelTo2 '_'). Therefore, the check should
be done on the original name of the type, which then fixes
issue #132.