Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup stuff after GHC-8.0 #216

Merged
merged 1 commit into from
May 17, 2020
Merged

Cleanup stuff after GHC-8.0 #216

merged 1 commit into from
May 17, 2020

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented May 16, 2020

  • Bump lower bounds of boot libraries
  • Remove (all!) of CPP, including overlapping-compat.h
  • Make few small cleanups elsewhere
  • Remove .ghci, use stack repl or cabal repl
  • Regenerate .travis.yml

@phadej phadej force-pushed the cleanups-ghc-8.10 branch 4 times, most recently from 4e915f6 to c697c01 Compare May 16, 2020 13:02
@phadej
Cleanup stuff after GHC-8.10
44ad73c 
- Bump lower bounds of boot libraries
- Remove (all!) of CPP, including overlapping-compat.h
- Make few small cleanups elsewhere
- Remove .ghci, use `stack repl` or `cabal repl`
- Regenerate .travis.yml
@phadej
Copy link
Collaborator Author

phadej commented May 16, 2020

CI green

fisx
fisx approved these changes May 17, 2020
View reviewed changes
Copy link
Collaborator

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little uncertain about my role / authority in this project, so I'll not merge this, but I like the changes a lot, thanks!

@phadej do you still have write access to the repo? Let me know if you want me to merge it. :)

@fizruk
Copy link
Member

fizruk commented May 17, 2020

Remove (all!) of CPP, including overlapping-compat.h

😱 This is amazing!

@phadej Thank you! 😊

@phadej phadej merged commit 228a301 into GetShopTV:master May 17, 2020
@phadej phadej changed the title Cleanup stuff after GHC-8.10 Cleanup stuff after GHC-8.0 May 17, 2020
@phadej phadej deleted the cleanups-ghc-8.10 branch May 17, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fizruk fizruk fizruk approved these changes

@fisx fisx fisx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phadej @fizruk @fisx