Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow text-2.0 #234

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Allow text-2.0 #234

merged 2 commits into from
Feb 7, 2022

Conversation

ysangkok
Copy link
Contributor

@ysangkok ysangkok commented Feb 6, 2022

Sadly the doctests fail because the ordering of the required keys changes with text-2.0. I don't know the source so well, so I havn't attempted fixing this.

Fails:

cabal test --constraint='text>=2' -w ghc-9.0.2

Passes:

cabal test --constraint='text<2' -w ghc-9.0.2

Thanks for your work!

@swamp-agr
Copy link
Collaborator

@ysangkok,

Could you please include CPP wrapper around failing doctests to support MIN_VERSION_text(2,0,0)?

The diff could be obtained from doctests results.

@ysangkok
Copy link
Contributor Author

ysangkok commented Feb 7, 2022

@swamp-agr I added the CPP as suggested.

@swamp-agr swamp-agr merged commit aca231e into GetShopTV:master Feb 7, 2022
@swamp-agr
Copy link
Collaborator

Thanks @ysangkok! I will make a minor release later today.

@swamp-agr
Copy link
Collaborator

swagger2-2.8.2 was released on Hackage: https://hackage.haskell.org/package/swagger2-2.8.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants