-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bytestring type errors #78
Conversation
@phadej can you review this? |
@@ -35,6 +38,13 @@ import Data.Swagger.Internal | |||
import Data.Swagger.Lens | |||
import Data.Swagger.SchemaOptions | |||
|
|||
#if __GLASGOW_HASKELL__ < 800 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't
#if __GLASGOW_HASKELL__ >= 800
be clearer, or is there a good reason to use <
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, no good reason. But I'll leave it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I can rebase and make a new release during the weekend. Would it be ok for you, @fizruk ? |
@phadej yes, that would be great! |
Done in #84 |
Closes #77.
Here are the errors: