Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i116] Extend PushMessage to access extra data #4940

Merged
merged 1 commit into from
Aug 30, 2023
Merged

[i116] Extend PushMessage to access extra data #4940

merged 1 commit into from
Aug 30, 2023

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Aug 30, 2023 •
edited
Loading

🎯 Goal

Closes: https://github.com/GetStream/android-internal-board/issues/116

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the v5 branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat added the v5 label Aug 30, 2023
@kanat kanat marked this pull request as ready for review August 30, 2023 21:56
@kanat kanat requested a review from a team as a code owner August 30, 2023 21:56
@kanat kanat added core enhancement New feature or request labels Aug 30, 2023
@kanat kanat enabled auto-merge (squash) August 30, 2023 22:22
@kanat kanat disabled auto-merge August 30, 2023 22:22
@kanat kanat merged commit a890f4c into v5 Aug 30, 2023
5 checks passed
@kanat kanat deleted the hotfix/push-messages-extra branch August 30, 2023 22:22
@kanat kanat mentioned this pull request Sep 5, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core enhancement New feature or request v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kanat