Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Remove the user is a member check for unreadIndicator. #1566

Merged
merged 2 commits into from
May 23, 2023

Conversation

xsahil03x
Copy link
Contributor

Fixes: #1482

Signed-off-by: xsahil03x <xdsahil@gmail.com>
Signed-off-by: xsahil03x <xdsahil@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (a666a6c) 58.49% compared to head (5210cd5) 58.50%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1566   +/-   ##
========================================
  Coverage    58.49%   58.50%           
========================================
  Files          290      290           
  Lines        17689    17688    -1     
========================================
  Hits         10348    10348           
+ Misses        7341     7340    -1     
Impacted Files Coverage Δ
.../channel_scroll_view/stream_channel_list_tile.dart 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xsahil03x xsahil03x force-pushed the fix/channel-list-tile-unread-count branch from 0bea5c2 to 5210cd5 Compare May 23, 2023 11:11
@xsahil03x xsahil03x merged commit a181a0c into develop May 23, 2023
@xsahil03x xsahil03x deleted the fix/channel-list-tile-unread-count branch May 23, 2023 11:11
@xsahil03x xsahil03x restored the fix/channel-list-tile-unread-count branch May 23, 2023 11:13
@xsahil03x xsahil03x deleted the fix/channel-list-tile-unread-count branch May 23, 2023 11:13
@xsahil03x xsahil03x mentioned this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There might be no indicator for unread messages for channels with 100+ members
2 participants