Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): add widget to avoid text overflow in StreamTypingIndicator #1771

Merged

Conversation

juanleondev
Copy link
Contributor

@juanleondev juanleondev commented Nov 7, 2023

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

I'm having an issue when the text in StreamTypingIndicator is larger than the available space. I added Flexible to avoid it and keep the row as small as possible.

@juanleondev juanleondev changed the title fix: add widget to avoid text overflow in StreamTypingIndicator ui: add widget to avoid text overflow in StreamTypingIndicator Nov 8, 2023
@juanleondev juanleondev changed the title ui: add widget to avoid text overflow in StreamTypingIndicator fix: add widget to avoid text overflow in StreamTypingIndicator Nov 8, 2023
@juanleondev juanleondev changed the title fix: add widget to avoid text overflow in StreamTypingIndicator fix(ui): add widget to avoid text overflow in StreamTypingIndicator Nov 8, 2023
@esarbanis esarbanis changed the base branch from develop to master December 4, 2023 15:08
Copy link
Contributor

@esarbanis esarbanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d1acdc) 59.16% compared to head (6f9bb75) 59.16%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1771   +/-   ##
=======================================
  Coverage   59.16%   59.16%           
=======================================
  Files         310      310           
  Lines       17804    17805    +1     
=======================================
+ Hits        10534    10535    +1     
  Misses       7270     7270           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esarbanis esarbanis merged commit 57ec442 into GetStream:master Feb 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants